From: John Ferlan <jferlan@redhat.com>
Date: Thu, 4 Sep 2014 13:37:21 +0000 (-0400)
Subject: storage: Resolve Coverity UNUSED_VALUE
X-Git-Tag: CVE-2014-3633~106
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8ea809df15f374945517e383ebd0d259dfcab9ef;p=thirdparty%2Flibvirt.git

storage: Resolve Coverity UNUSED_VALUE

Since cd4d547576a4f0371d1d4d4e0ca6db124c5ba257

Coverity notes that setting 'ret = -3' prior to the unconditional
setting of 'ret = 0' will cause the value to be UNUSED.

Since the comment indicates that it is expect to allow the code
to continue, just remove the ret = -3 setting.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
index b8f907aee1..0f8ceee549 100644
--- a/src/storage/storage_backend_fs.c
+++ b/src/storage/storage_backend_fs.c
@@ -128,7 +128,6 @@ virStorageBackendProbeTarget(virStorageSourcePtr target,
                 virReportError(VIR_ERR_INTERNAL_ERROR,
                                _("cannot probe backing volume format: %s"),
                                target->backingStore->path);
-                ret = -3;
             } else {
                 target->backingStore->format = rc;
             }