From: Victor Julien <victor@inliniac.net>
Date: Mon, 4 Jan 2021 21:10:58 +0000 (+0100)
Subject: stream/sack: minor debug improvements
X-Git-Tag: suricata-7.0.0-beta1~1553
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8eccd02c94a477d6207d9e1d6569549a42b70604;p=thirdparty%2Fsuricata.git

stream/sack: minor debug improvements
---

diff --git a/src/stream-tcp-sack.c b/src/stream-tcp-sack.c
index cb60c525b9..f26c5ebab0 100644
--- a/src/stream-tcp-sack.c
+++ b/src/stream-tcp-sack.c
@@ -184,7 +184,7 @@ static inline void ConsolidateBackward(TcpStream *stream,
 
 static int Insert(TcpStream *stream, struct TCPSACK *tree, uint32_t le, uint32_t re)
 {
-    SCLogDebug("* inserting: %u/%u\n", le, re);
+    SCLogDebug("inserting: %u-%u", le, re);
 
     struct StreamTcpSackRecord *sa = StreamTcpSackRecordAlloc();
     if (unlikely(sa == NULL))
@@ -248,11 +248,13 @@ static int StreamTcpSackInsertRange(TcpStream *stream, uint32_t le, uint32_t re)
  */
 int StreamTcpSackUpdatePacket(TcpStream *stream, Packet *p)
 {
+    SCEnter();
+
     const int records = TCP_GET_SACK_CNT(p);
     const uint8_t *data = TCP_GET_SACK_PTR(p);
 
     if (records == 0 || data == NULL)
-        return 0;
+        SCReturnInt(0);
 
     TCPOptSackRecord rec[records], *sack_rec = rec;
     memcpy(&rec, data, sizeof(TCPOptSackRecord) * records);