From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Wed, 7 May 2025 13:06:43 +0000 (+0200)
Subject: dnsdist: The second parameter to `setAPIWritable()` is optional
X-Git-Tag: dnsdist-2.0.0-alpha2~21^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8ede3d085619969de29cb7944922acaf3f089070;p=thirdparty%2Fpdns.git

dnsdist: The second parameter to `setAPIWritable()` is optional

This was broken 93cd7bf30d and not noticed because our regression
tests provide the optional parameter.
---

diff --git a/pdns/dnsdistdist/dnsdist-lua.cc b/pdns/dnsdistdist/dnsdist-lua.cc
index 233f7a6da2..c7c19071d2 100644
--- a/pdns/dnsdistdist/dnsdist-lua.cc
+++ b/pdns/dnsdistdist/dnsdist-lua.cc
@@ -1914,7 +1914,7 @@ static void setupLuaConfig(LuaContext& luaCtx, bool client, bool configCheck)
     }
     dnsdist::configuration::updateRuntimeConfiguration([writable, &apiConfigDir](dnsdist::configuration::RuntimeConfiguration& config) {
       config.d_apiReadWrite = writable;
-      if (!(*apiConfigDir).empty()) {
+      if (apiConfigDir && !(*apiConfigDir).empty()) {
         config.d_apiConfigDirectory = *apiConfigDir;
       }
     });