From: Philippe Antoine <pantoine@oisf.net>
Date: Tue, 17 Jun 2025 07:48:22 +0000 (+0200)
Subject: dns: remove never run check
X-Git-Tag: suricata-7.0.11~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8ee0e14764a309dfecfc4ef96121bcdfcc48a0ae;p=thirdparty%2Fsuricata-verify.git

dns: remove never run check

As version requirement for check was incompatible with the one
from the test
---

diff --git a/tests/dns/dns-invalid-opcode/test.yaml b/tests/dns/dns-invalid-opcode/test.yaml
index 44bc7be34..a9fe134c9 100644
--- a/tests/dns/dns-invalid-opcode/test.yaml
+++ b/tests/dns/dns-invalid-opcode/test.yaml
@@ -72,43 +72,6 @@ checks:
       src_ip: 1.1.1.1
       src_port: 5333
       tx_id: 0
-
-- filter:
-    lt-version: 8
-    count: 1
-    match:
-      alert.action: allowed
-      alert.category: Generic Protocol Command Decode
-      alert.gid: 1
-      alert.rev: 1
-      alert.severity: 3
-      alert.signature: SURICATA DNS Invalid opcode
-      alert.signature_id: 2240007
-      app_proto: dns
-      dest_ip: 2.2.2.2
-      dest_port: 53
-      direction: to_server
-      dns.query[0].id: 1
-      dns.query[0].opcode: 9
-      dns.query[0].rrname: suricata.io
-      dns.query[0].rrtype: A
-      dns.query[0].tx_id: 0
-      dns.query[0].type: query
-      event_type: alert
-      flow.bytes_toclient: 0
-      flow.bytes_toserver: 71
-      flow.dest_ip: 2.2.2.2
-      flow.dest_port: 53
-      flow.pkts_toclient: 0
-      flow.pkts_toserver: 1
-      flow.src_ip: 1.1.1.1
-      flow.src_port: 5333
-      pcap_cnt: 1
-      pkt_src: wire/pcap
-      proto: UDP
-      src_ip: 1.1.1.1
-      src_port: 5333
-      tx_id: 0
 - filter:
     count: 1
     match:
@@ -182,46 +145,6 @@ checks:
       src_ip: 2.2.2.2
       src_port: 53
       tx_id: 1
-- filter:
-    requires:
-      lt-version: 8
-    count: 1
-    match:
-      alert.action: allowed
-      alert.category: Generic Protocol Command Decode
-      alert.gid: 1
-      alert.rev: 1
-      alert.severity: 3
-      alert.signature: SURICATA DNS Invalid opcode
-      alert.signature_id: 2240007
-      app_proto: dns
-      dest_ip: 1.1.1.1
-      dest_port: 5333
-      direction: to_client
-      dns.answer.flags: c800
-      dns.answer.id: 1
-      dns.answer.opcode: 9
-      dns.answer.qr: true
-      dns.answer.rcode: NOERROR
-      dns.answer.rrname: suricata.io
-      dns.answer.rrtype: A
-      dns.answer.type: answer
-      dns.answer.version: 2
-      event_type: alert
-      flow.bytes_toclient: 98
-      flow.bytes_toserver: 71
-      flow.dest_ip: 2.2.2.2
-      flow.dest_port: 53
-      flow.pkts_toclient: 1
-      flow.pkts_toserver: 1
-      flow.src_ip: 1.1.1.1
-      flow.src_port: 5333
-      pcap_cnt: 2
-      pkt_src: wire/pcap
-      proto: UDP
-      src_ip: 2.2.2.2
-      src_port: 53
-      tx_id: 1
 - filter:
     count: 1
     match:
diff --git a/tests/dns/dns-rrtype/test.yaml b/tests/dns/dns-rrtype/test.yaml
index d706bfcd6..ef75fdde1 100644
--- a/tests/dns/dns-rrtype/test.yaml
+++ b/tests/dns/dns-rrtype/test.yaml
@@ -18,20 +18,6 @@ checks:
         dns.queries[0].rrtype: A
         src_ip: 10.16.1.11
         src_port: 57634
-  - filter:
-      requires:
-        lt-version: 8
-      count: 1
-      match:
-        alert.signature_id: 1
-        dest_ip: 10.16.1.1
-        dest_port: 53
-        direction: to_server
-        app_proto: dns
-        event_type: alert
-        dns.query[0].rrtype: A
-        src_ip: 10.16.1.11
-        src_port: 57634
   - filter:
       count: 1
       match:
diff --git a/tests/dns/dns-z-bit/test.yaml b/tests/dns/dns-z-bit/test.yaml
index b8e2fa786..ba3ac8741 100644
--- a/tests/dns/dns-z-bit/test.yaml
+++ b/tests/dns/dns-z-bit/test.yaml
@@ -11,14 +11,6 @@ checks:
       event_type: dns
       dns.type: request
       dns.z: true
-- filter:
-    requires:
-      lt-version: 8
-    count: 1
-    match:
-      event_type: alert
-      alert.signature_id: 2240006
-      dns.query[0].z: true
 - filter:
     requires:
       min-version: 8