From: Rosen Penev <rosenp@gmail.com>
Date: Thu, 5 Nov 2020 09:05:25 +0000 (-0800)
Subject: clang-tidy: add reserve
X-Git-Tag: dnsdist-1.6.0-alpha2~55^2~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8ef7c15d727cb2b8d61ee22c19962c0c13aba691;p=thirdparty%2Fpdns.git

clang-tidy: add reserve

Found with performance-inefficient-vector-operation

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---

diff --git a/pdns/backends/gsql/gsqlbackend.cc b/pdns/backends/gsql/gsqlbackend.cc
index 8c204b0ec2..2b2c292554 100644
--- a/pdns/backends/gsql/gsqlbackend.cc
+++ b/pdns/backends/gsql/gsqlbackend.cc
@@ -226,6 +226,7 @@ void GSQLBackend::setFresh(uint32_t domain_id)
 bool GSQLBackend::setMasters(const DNSName &domain, const vector<ComboAddress> &masters)
 {
   vector<string> masters_s;
+  masters_s.reserve(masters.size());
   for (const auto& master : masters) {
     masters_s.push_back(master.toStringWithPortExcept(53));
   }
@@ -1271,6 +1272,7 @@ bool GSQLBackend::superMasterBackend(const string &ip, const DNSName &domain, co
 bool GSQLBackend::createDomain(const DNSName &domain, const DomainInfo::DomainKind kind, const vector<ComboAddress> &masters, const string &account)
 {
   vector<string> masters_s;
+  masters_s.reserve(masters.size());
   for (const auto& master : masters) {
     masters_s.push_back(master.toStringWithPortExcept(53));
   }
diff --git a/pdns/lua-record.cc b/pdns/lua-record.cc
index 8d51c7937e..3878f4745a 100644
--- a/pdns/lua-record.cc
+++ b/pdns/lua-record.cc
@@ -488,6 +488,7 @@ static vector<string> convIpListToString(const vector<ComboAddress> &comboAddres
 {
   vector<string> ret;
 
+  ret.reserve(comboAddresses.size());
   for (const auto& c : comboAddresses) {
     ret.emplace_back(c.toString());
   }
@@ -510,6 +511,7 @@ static vector<pair<int, ComboAddress> > convWIplist(std::unordered_map<int, wipl
 {
   vector<pair<int,ComboAddress> > ret;
 
+  ret.reserve(src.size());
   for(const auto& i : src) {
     ret.emplace_back(atoi(i.second.at(1).c_str()), ComboAddress(i.second.at(2)));
   }
@@ -834,6 +836,7 @@ static void setupLuaRecords()
   lua.writeFunction("pickwhashed", [](std::unordered_map<int, wiplist_t > ips) {
       vector<pair<int,ComboAddress> > conv;
 
+      conv.reserve(ips.size());
       for(auto& i : ips)
         conv.emplace_back(atoi(i.second[1].c_str()), ComboAddress(i.second[2]));
 
diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc
index a1fed7739c..52385275ae 100644
--- a/pdns/pdnsutil.cc
+++ b/pdns/pdnsutil.cc
@@ -56,6 +56,7 @@ ArgvMap &arg()
 
 static std::string comboAddressVecToString(const std::vector<ComboAddress>& vec) {
   vector<string> strs;
+  strs.reserve(vec.size());
   for (const auto& ca : vec) {
     strs.push_back(ca.toStringWithPortExcept(53));
   }