From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Sat, 7 Dec 2019 09:37:00 +0000 (+1300)
Subject: selftest: enable perl warnings
X-Git-Tag: ldb-2.1.1~205
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f17d48163014266c191f8035c5c72fb4f8a5a01;p=thirdparty%2Fsamba.git

selftest: enable perl warnings

After this we will see more noise with each test run, and these
warnings will be addressed in following commits.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/selftest/SocketWrapper.pm b/selftest/SocketWrapper.pm
index ef8058da794..67a4ec96ca6 100644
--- a/selftest/SocketWrapper.pm
+++ b/selftest/SocketWrapper.pm
@@ -24,6 +24,7 @@ use Exporter;
 @EXPORT_OK = qw(setup_dir setup_pcap set_default_iface);
 
 use strict;
+use warnings;
 use FindBin qw($RealBin);
 
 sub setup_dir($$)
diff --git a/selftest/Subunit.pm b/selftest/Subunit.pm
index 07f4b8ff97d..07f3ac28ddf 100644
--- a/selftest/Subunit.pm
+++ b/selftest/Subunit.pm
@@ -22,6 +22,7 @@ require Exporter;
 @ISA = qw(Exporter);
 
 use strict;
+use warnings;
 
 sub start_test($)
 {
diff --git a/selftest/selftest.pl b/selftest/selftest.pl
index b6094fef3b9..a1f2183a4cc 100755
--- a/selftest/selftest.pl
+++ b/selftest/selftest.pl
@@ -17,6 +17,7 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 use strict;
+use warnings;
 
 use FindBin qw($RealBin $Script);
 use File::Spec;
diff --git a/selftest/target/Samba.pm b/selftest/target/Samba.pm
index a908a7ade7c..0cfa5c57dd5 100644
--- a/selftest/target/Samba.pm
+++ b/selftest/target/Samba.pm
@@ -6,6 +6,7 @@
 package Samba;
 
 use strict;
+use warnings;
 use target::Samba3;
 use target::Samba4;
 use POSIX;
diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index 991963b6074..a9d713d6a3b 100755
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -9,6 +9,7 @@
 package Samba3;
 
 use strict;
+use warnings;
 use Cwd qw(abs_path);
 use FindBin qw($RealBin);
 use POSIX;
diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index da9f0a00e91..89f0615fabd 100755
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -9,6 +9,7 @@
 package Samba4;
 
 use strict;
+use warnings;
 use Cwd qw(abs_path);
 use FindBin qw($RealBin);
 use POSIX;