From: Phil Sutter <phil@nwl.cc>
Date: Thu, 14 Dec 2017 19:40:22 +0000 (+0100)
Subject: object: Avoid returning garbage in nftnl_obj_do_parse()
X-Git-Tag: libnftnl-1.0.9~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f228f6842494ea7f83ff9aaa19ec32681628c9f;p=thirdparty%2Flibnftnl.git

object: Avoid returning garbage in nftnl_obj_do_parse()

It may happen that 'perr' variable does not get initialized, so making
parameter 'err' point to it in any case is error-prone. Avoid this by
initializing 'perr' upon declaration.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/src/object.c b/src/object.c
index 9a4ee712..da3423bf 100644
--- a/src/object.c
+++ b/src/object.c
@@ -358,7 +358,7 @@ static int nftnl_obj_do_parse(struct nftnl_obj *obj, enum nftnl_parse_type type,
 			      const void *data, struct nftnl_parse_err *err,
 			      enum nftnl_parse_input input)
 {
-	struct nftnl_parse_err perr;
+	struct nftnl_parse_err perr = {};
 	int ret;
 
 	switch (type) {