From: Daniel Salzman <daniel.salzman@nic.cz>
Date: Wed, 27 May 2020 11:34:47 +0000 (+0200)
Subject: query_module: fix possbile NULL pointer dereference in knotd_mod_stats_free
X-Git-Tag: v3.0.0~104
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f32f1503cf2ef7465bcbbda8e360ecaf3cf5798;p=thirdparty%2Fknot-dns.git

query_module: fix possbile NULL pointer dereference in knotd_mod_stats_free
---

diff --git a/src/knot/nameserver/query_module.c b/src/knot/nameserver/query_module.c
index 152c10b930..f93b810d60 100644
--- a/src/knot/nameserver/query_module.c
+++ b/src/knot/nameserver/query_module.c
@@ -311,10 +311,11 @@ void knotd_mod_stats_free(knotd_mod_t *mod)
 		return;
 	}
 
-	unsigned threads = knotd_mod_threads(mod);
-
-	for (unsigned i = 0; i < threads; i++) {
-		free(mod->stats_vals[i]);
+	if (mod->stats_vals != NULL) {
+		unsigned threads = knotd_mod_threads(mod);
+		for (unsigned i = 0; i < threads; i++) {
+			free(mod->stats_vals[i]);
+		}
 	}
 
 	free(mod->stats_vals);