From: jocuri%softhome.net <> Date: Tue, 14 Dec 2004 09:59:58 +0000 (+0000) Subject: Patch for bug 274236: Variable component overlaps in ThrowCodeError; patch by me... X-Git-Tag: bugzilla-2.18~53 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f5dd735792b387efff5f71a32cbb4817e76f190;p=thirdparty%2Fbugzilla.git Patch for bug 274236: Variable component overlaps in ThrowCodeError; patch by me, r=wurblzap (Marc), a=justdave. --- diff --git a/editflagtypes.cgi b/editflagtypes.cgi index 359078c102..b172cd996a 100755 --- a/editflagtypes.cgi +++ b/editflagtypes.cgi @@ -468,7 +468,7 @@ sub validateComponent { defined($component_id) || ThrowCodeError("flag_type_component_nonexistent", { product => $::FORM{'product'}, - component => $::FORM{'component'} }); + name => $::FORM{'component'} }); } sub validateSortKey { diff --git a/process_bug.cgi b/process_bug.cgi index 0854ac8441..2c4e96dd38 100755 --- a/process_bug.cgi +++ b/process_bug.cgi @@ -709,7 +709,7 @@ if ($::FORM{'component'} ne $::FORM{'dontchange'}) { $comp_id = get_component_id($prod_id, $::FORM{'component'}); $comp_id || ThrowCodeError("invalid_component", - {component => $::FORM{'component'}, + {name => $::FORM{'component'}, product => $::FORM{'product'}}); DoComma(); diff --git a/template/en/default/global/code-error.html.tmpl b/template/en/default/global/code-error.html.tmpl index 7919471357..cbca4f1d14 100644 --- a/template/en/default/global/code-error.html.tmpl +++ b/template/en/default/global/code-error.html.tmpl @@ -125,7 +125,7 @@ [% ELSIF error == "invalid_component" %] [% title = "Invalid Component" %] - The [% component FILTER html %] component doesn't exist in the + The [% name FILTER html %] component doesn't exist in the [% product FILTER html %] product. [% ELSIF error == "invalid_dimensions" %] @@ -154,7 +154,7 @@ is invalid. [% ELSIF error == "flag_type_component_nonexistent" %] - The component [% component FILTER html %] does not exist + The component [% name FILTER html %] does not exist in the product [% product FILTER html %]. [% ELSIF error == "flag_type_component_without_product" %]