From: Stefan Eissing <icing@apache.org>
Date: Thu, 24 Mar 2022 10:03:59 +0000 (+0000)
Subject:   *) mod_http2: in a recent change, code was removed that prevented connections
X-Git-Tag: 2.5.0-alpha2-ci-test-only~436
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f642ea4363fa351e8ed5f18a8964e3edc214036;p=thirdparty%2Fapache%2Fhttpd.git

  *) mod_http2: in a recent change, code was removed that prevented connections
     with many parallel streams to stall. Re-added that, slightly improved and
     with a comment that explains the need for future humans.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1899169 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/http2/h2_mplx.c b/modules/http2/h2_mplx.c
index 7f54de87a87..1557449785b 100644
--- a/modules/http2/h2_mplx.c
+++ b/modules/http2/h2_mplx.c
@@ -291,9 +291,6 @@ h2_mplx *h2_mplx_c1_create(h2_stream *stream0, server_rec *s, apr_pool_t *parent
                                      m->pool);
     if (APR_SUCCESS != status) goto failure;
 
-    status = apr_thread_cond_create(&m->join_wait, m->pool);
-    if (APR_SUCCESS != status) goto failure;
-
     m->max_streams = h2_config_sgeti(s, H2_CONF_MAX_STREAMS);
     m->stream_max_mem = h2_config_sgeti(s, H2_CONF_STREAM_MAX_MEM);
 
@@ -467,7 +464,11 @@ void h2_mplx_c1_destroy(h2_mplx *m)
     /* 3. while workers are busy on this connection, meaning they
      *    are processing streams from this connection, wait on them finishing
      *    in order to wake us and let us check again. 
-     *    Eventually, this has to succeed. */    
+     *    Eventually, this has to succeed. */
+    if (!m->join_wait) {
+        apr_thread_cond_create(&m->join_wait, m->pool);
+    }
+
     for (i = 0; h2_ihash_count(m->shold) > 0; ++i) {
         status = apr_thread_cond_timedwait(m->join_wait, m->lock, apr_time_from_sec(wait_secs));
         
@@ -967,7 +968,22 @@ void h2_mplx_worker_c2_done(conn_rec *c2)
 
     --m->processing_count;
     s_c2_done(m, c2, conn_ctx);
-    apr_thread_cond_signal(m->join_wait);
+    if (m->join_wait) apr_thread_cond_signal(m->join_wait);
+
+    if (!m->aborted && !m->is_registered
+        && (m->processing_count < m->processing_limit)
+        && !h2_iq_empty(m->q)) {
+        /* We have a limit on the amount of c2s we process at a time. When
+         * this is reached, we do no longer have things to do for h2 workers
+         * and they remove such an mplx from its queue.
+         * When a c2 is done, there might then be room for more processing
+         * and we need then to register this mplx at h2 workers again.
+         */
+        m->is_registered = 1;
+        H2_MPLX_LEAVE(m);
+        h2_workers_register(m->workers, m);
+        return;
+    }
 
     H2_MPLX_LEAVE(m);
 }