From: drh <>
Date: Fri, 6 Mar 2026 23:37:45 +0000 (+0000)
Subject: Fix a memory leak in the decimal extension that follows an OOM.
X-Git-Tag: major-release~109^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f65da4574021d5f526de7486eefb31a4f95ad71;p=thirdparty%2Fsqlite.git

Fix a memory leak in the decimal extension that follows an OOM.

FossilOrigin-Name: 8d59e47e7ae0aae01cb25c6c054cf9a4d9651e858bc0dd1a0e2a013ec6579012
---

diff --git a/ext/misc/decimal.c b/ext/misc/decimal.c
index 796c510a43..50f6ce511c 100644
--- a/ext/misc/decimal.c
+++ b/ext/misc/decimal.c
@@ -128,9 +128,10 @@ static Decimal *decimalNewFromText(const char *zIn, int n){
       }
     }
     if( iExp>0 ){   
-      p->a = sqlite3_realloc64(p->a, (sqlite3_int64)p->nDigit
+      signed char *a = sqlite3_realloc64(p->a, (sqlite3_int64)p->nDigit
                                      + (sqlite3_int64)iExp + 1 );
-      if( p->a==0 ) goto new_from_text_failed;
+      if( a==0 ) goto new_from_text_failed;
+      p->a = a;
       memset(p->a+p->nDigit, 0, iExp);
       p->nDigit += iExp;
     }
@@ -148,9 +149,10 @@ static Decimal *decimalNewFromText(const char *zIn, int n){
       }
     }
     if( iExp>0 ){
-      p->a = sqlite3_realloc64(p->a, (sqlite3_int64)p->nDigit
+      signed char *a = sqlite3_realloc64(p->a, (sqlite3_int64)p->nDigit
                                      + (sqlite3_int64)iExp + 1 );
-      if( p->a==0 ) goto new_from_text_failed;
+      if( a==0 ) goto new_from_text_failed;
+      p->a = a;
       memmove(p->a+iExp, p->a, p->nDigit);
       memset(p->a, 0, iExp);
       p->nDigit += iExp;
diff --git a/manifest b/manifest
index 75f92ac375..872a56c9c7 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Rename\sthe\sinitializer\sfunctions\sfor\sbase64()\sand\sbase85()\sto\sinclude\sthe\nnumber\sat\sthe\send.
-D 2026-03-06T22:09:39.887
+C Fix\sa\smemory\sleak\sin\sthe\sdecimal\sextension\sthat\sfollows\san\sOOM.
+D 2026-03-06T23:37:45.381
 F .fossil-settings/binary-glob 61195414528fb3ea9693577e1980230d78a1f8b0a54c78cf1b9b24d0a409ed6a x
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
@@ -370,7 +370,7 @@ F ext/misc/completion.c c27b64fdd0943c1b7f152376599814cee2641f7d67a7bb9bd2b957c2
 F ext/misc/compress.c 8191118b9b73e7796c961790db62d35d9b0fb724b045e005a5713dc9e0795565
 F ext/misc/csv.c e82124eabee0e692d7b90ab8b2c34fadbf7b375279f102567fa06e4da4b771bf
 F ext/misc/dbdump.c 678f1b9ae2317b4473f65d03132a2482c3f4b08920799ed80feedd2941a06680
-F ext/misc/decimal.c e365fa7e6f1f44a36150cb137c842635341333a1249cd29eb615a5bebdccd841
+F ext/misc/decimal.c ab8525b6870735e9991700c605977b697484c57a161729c810c37edb515c45a2
 F ext/misc/eval.c 04bc9aada78c888394204b4ed996ab834b99726fb59603b0ee3ed6e049755dc1
 F ext/misc/explain.c 606100185fb90d6a1eade1ed0414d53503c86820d8956a06e3b0a56291894f2b
 F ext/misc/fileio.c 33165b3cd99f83dcd333a338eb51491f6b01c8d96cb6ae81f96a6a096834e030
@@ -2189,8 +2189,8 @@ F tool/warnings-clang.sh bbf6a1e685e534c92ec2bfba5b1745f34fb6f0bc2a362850723a9ee
 F tool/warnings.sh d924598cf2f55a4ecbc2aeb055c10bd5f48114793e7ba25f9585435da29e7e98
 F tool/win/sqlite.vsix deb315d026cc8400325c5863eef847784a219a2f
 F tool/winmain.c 00c8fb88e365c9017db14c73d3c78af62194d9644feaf60e220ab0f411f3604c
-P 94a650b169bfd1056995c1cfe584d3d92667bce5e9cf93e6381607ed87251bf3
-R 989a666377fa6d7e98c6cb3b06508470
+P af18b68978ec9b1ff732505bfb92bb65e4f7381b904123f42c638b747569fa28
+R 11f0753acd82d511ab8c1d1c160af2a5
 U drh
-Z e6a51fa6f64f4c1724ac4878d85b6bf3
+Z 81ddf101166dcc9f59cb1dc6cb89c1a9
 # Remove this line to create a well-formed Fossil manifest.
diff --git a/manifest.uuid b/manifest.uuid
index ce33b12c89..9659f9a3cb 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-af18b68978ec9b1ff732505bfb92bb65e4f7381b904123f42c638b747569fa28
+8d59e47e7ae0aae01cb25c6c054cf9a4d9651e858bc0dd1a0e2a013ec6579012