From: Richard Guenther <rguenther@suse.de>
Date: Tue, 12 Feb 2008 21:26:49 +0000 (+0000)
Subject: re PR middle-end/35163 (folding comparison loses cast)
X-Git-Tag: releases/gcc-4.3.0~185
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f768a5a18a47ce412c6455a6e802d4b703fcf26;p=thirdparty%2Fgcc.git

re PR middle-end/35163 (folding comparison loses cast)

2008-02-12  Richard Guenther  <rguenther@suse.de>

	PR middle-end/35163
	* fold-const.c (fold_widened_comparison): Use get_unwidened in
	value-preserving mode.  Disallow final truncation.

	* gcc.c-torture/execute/pr35163.c: New testcase.

From-SVN: r132269
---

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 36e3c4692863..61d1567fa6d0 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2008-02-12  Richard Guenther  <rguenther@suse.de>
+
+	PR middle-end/35163
+	* fold-const.c (fold_widened_comparison): Use get_unwidened in
+	value-preserving mode.  Disallow final truncation.
+
 2008-02-12  Eric Botcazou  <ebotcazou@adacore.com>
 
 	PR middle-end/35136
diff --git a/gcc/fold-const.c b/gcc/fold-const.c
index ea0b43e942d2..a33b2b07a466 100644
--- a/gcc/fold-const.c
+++ b/gcc/fold-const.c
@@ -7045,12 +7045,14 @@ fold_widened_comparison (enum tree_code code, tree type, tree arg0, tree arg1)
   if (TYPE_PRECISION (TREE_TYPE (arg0)) <= TYPE_PRECISION (shorter_type))
     return NULL_TREE;
 
-  arg1_unw = get_unwidened (arg1, shorter_type);
+  arg1_unw = get_unwidened (arg1, NULL_TREE);
 
   /* If possible, express the comparison in the shorter mode.  */
   if ((code == EQ_EXPR || code == NE_EXPR
        || TYPE_UNSIGNED (TREE_TYPE (arg0)) == TYPE_UNSIGNED (shorter_type))
       && (TREE_TYPE (arg1_unw) == shorter_type
+	  || (TYPE_PRECISION (shorter_type)
+	      >= TYPE_PRECISION (TREE_TYPE (arg1_unw)))
 	  || (TREE_CODE (arg1_unw) == INTEGER_CST
 	      && (TREE_CODE (shorter_type) == INTEGER_TYPE
 		  || TREE_CODE (shorter_type) == BOOLEAN_TYPE)
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 3fc12f55317a..00a713e9941c 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2008-02-12  Richard Guenther  <rguenther@suse.de>
+
+	PR middle-end/35163
+	* gcc.c-torture/execute/pr35163.c: New testcase.
+
 2008-02-12  Uros Bizjak  <ubizjak@gmail.com>
 
 	* gcc.target/i386/asm-3.c: Fix dg-skip-if for all 32bit PIC targets.
diff --git a/gcc/testsuite/gcc.c-torture/execute/pr35163.c b/gcc/testsuite/gcc.c-torture/execute/pr35163.c
new file mode 100644
index 000000000000..4950d6d2027d
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/execute/pr35163.c
@@ -0,0 +1,11 @@
+extern void abort(void);
+
+int main()
+{
+  signed char a = -30;
+  signed char b = -31;
+  if (a > (unsigned short)b)
+    abort ();
+  return 0;
+}
+