From: Eric Blake <eblake@redhat.com>
Date: Thu, 13 Oct 2011 21:06:01 +0000 (-0600)
Subject: storage: plug memory leak on error
X-Git-Tag: v0.9.7-rc1~109
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f8258e1df1f84b4de98cc974289a6a4030bb91f;p=thirdparty%2Flibvirt.git

storage: plug memory leak on error

Detected by Coverity.  Present since commit 82c1740.

* src/storage/storage_backend_logical.c
(virStorageBackendLogicalMakeVol): Fix leak.
---

diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c
index 51624a7ed0..50d0407dcd 100644
--- a/src/storage/storage_backend_logical.c
+++ b/src/storage/storage_backend_logical.c
@@ -236,6 +236,7 @@ virStorageBackendLogicalMakeVol(virStoragePoolObjPtr pool,
         if (virStrToLong_ull(offset_str, NULL, 10, &offset) < 0) {
             virStorageReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                                   _("malformed volume extent offset value"));
+            VIR_FREE(offset_str);
             goto cleanup;
         }