From: Philippe Antoine <contact@catenacyber.fr>
Date: Mon, 13 Sep 2021 09:22:36 +0000 (+0200)
Subject: rust: right condition for both uint to be zero
X-Git-Tag: suricata-7.0.0-beta1~1237
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f8823b6f2b0a26b551397b8b574104bfd37e9f5;p=thirdparty%2Fsuricata.git

rust: right condition for both uint to be zero

Theay can overflow leading to their addition to be zero

If a NFS read reply indicates a count of 0xFFFFFFFF

Bug: #4680.
---

diff --git a/rust/src/filetracker.rs b/rust/src/filetracker.rs
index bf9d5be96f..f9a5c83be3 100644
--- a/rust/src/filetracker.rs
+++ b/rust/src/filetracker.rs
@@ -170,7 +170,7 @@ impl FileTransferTracker {
             SCLogDebug!("is_gap {} size {} ooo? {}", is_gap, gap_size, self.chunk_is_ooo);
         }
 
-        if self.chunk_left + self.fill_bytes as u32 == 0 {
+        if self.chunk_left == 0 && self.fill_bytes == 0 {
             //SCLogDebug!("UPDATE: nothing to do");
             if self.chunk_is_last == true {
                 SCLogDebug!("last empty chunk, closing");