From: wurblzap%gmail.com <>
Date: Fri, 31 Mar 2006 06:22:08 +0000 (+0000)
Subject: Bug 306695: Boolean charts forgets "0" values.
X-Git-Tag: bugzilla-2.23.1~36
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f893f4d3aa0c635193b2f4240fc707bd31846ac;p=thirdparty%2Fbugzilla.git

Bug 306695: Boolean charts forgets "0" values.
Patch by Marc Schumann <wurblzap@gmail.com>,
r=LpSolit, bugreport, a=justdave
---

diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm
index b722aee3d3..bc2d39b998 100644
--- a/Bugzilla/CGI.pm
+++ b/Bugzilla/CGI.pm
@@ -116,7 +116,7 @@ sub canonicalise_query {
         my $esc_key = url_quote($key);
 
         foreach my $value ($self->param($key)) {
-            if ($value) {
+            if (defined($value)) {
                 my $esc_value = url_quote($value);
 
                 push(@parameters, "$esc_key=$esc_value");
diff --git a/query.cgi b/query.cgi
index bda05d7aa0..7286a4b2ea 100755
--- a/query.cgi
+++ b/query.cgi
@@ -314,9 +314,13 @@ for (my $chart = 0; $cgi->param("field$chart-0-0"); $chart++) {
     for (my $row = 0; $cgi->param("field$chart-$row-0"); $row++) {
         my @cols;
         for (my $col = 0; $cgi->param("field$chart-$row-$col"); $col++) {
+            my $value = $cgi->param("value$chart-$row-$col");
+            if (!defined($value)) {
+                $value = '';
+            }
             push(@cols, { field => $cgi->param("field$chart-$row-$col"),
                           type => $cgi->param("type$chart-$row-$col") || 'noop',
-                          value => $cgi->param("value$chart-$row-$col") || '' });
+                          value => $value });
         }
         push(@rows, \@cols);
     }