From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Thu, 8 Aug 2019 14:55:08 +0000 (+0400)
Subject: qemu-migration: prevent migration if dbus-vmstate is required
X-Git-Tag: v5.8.0-rc1~255
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f8bba115d5ced7e764074161276e89595cd6be3;p=thirdparty%2Flibvirt.git

qemu-migration: prevent migration if dbus-vmstate is required

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 6ff956b1f5..d1553b126a 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1105,6 +1105,7 @@ qemuMigrationSrcIsAllowed(virQEMUDriverPtr driver,
                           bool remote,
                           unsigned int flags)
 {
+    qemuDomainObjPrivatePtr priv = vm->privateData;
     int nsnapshots;
     int pauseReason;
     size_t i;
@@ -1131,7 +1132,13 @@ qemuMigrationSrcIsAllowed(virQEMUDriverPtr driver,
                            _("cannot migrate domain with I/O error"));
             return false;
         }
+    }
 
+    if (virHashSize(priv->dbusVMStates) > 0 &&
+        !virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DBUS_VMSTATE)) {
+        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
+                       _("domain requires dbus-vmstate support"));
+        return false;
     }
 
     /* following checks don't make sense for offline migration */