From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 1 Aug 2013 14:33:23 +0000 (+0200)
Subject: qemumonitortestutils: Don't skip va_end() on error path
X-Git-Tag: CVE-2013-4239~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f95d5d84c0387b9c52ff2d2b557e093e02e0481;p=thirdparty%2Flibvirt.git

qemumonitortestutils: Don't skip va_end() on error path

When allocation of memory failed the error path didn't call va_end()
causing a coverity failure.

Reported by John Ferlan.
---

diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c
index fb76156a57..5697946459 100644
--- a/tests/qemumonitortestutils.c
+++ b/tests/qemumonitortestutils.c
@@ -669,7 +669,7 @@ qemuMonitorTestAddItemParams(qemuMonitorTestPtr test,
     va_start(args, response);
 
     if (VIR_ALLOC(data) < 0)
-        return -1;
+        goto error;
 
     if (VIR_STRDUP(data->command_name, cmdname) < 0 ||
         VIR_STRDUP(data->response, response) < 0)