From: Stephen Hemminger Date: Sun, 2 Feb 2020 12:20:58 +0000 (-0800) Subject: devlink: fix warning from unchecked write X-Git-Tag: v5.6.0~16 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8f9f2b9cdfbd1c7988542d81db1db854d48f2b0d;p=thirdparty%2Fiproute2.git devlink: fix warning from unchecked write Warning seen on Ubuntu devlink.c: In function ‘cmd_dev_flash’: devlink.c:3071:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] 3071 | write(pipe_w, &err, sizeof(err)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 9b13cddfe268 ("devlink: implement flash status monitoring") Signed-off-by: Stephen Hemminger --- diff --git a/devlink/devlink.c b/devlink/devlink.c index 73ce98654..f9e58c1d7 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -3066,11 +3066,13 @@ static int cmd_dev_flash(struct dl *dl) /* In child, just execute the flash and pass returned * value through pipe once it is done. */ + int cc; + close(pipe_r); err = _mnlg_socket_send(dl->nlg, nlh); - write(pipe_w, &err, sizeof(err)); + cc = write(pipe_w, &err, sizeof(err)); close(pipe_w); - exit(0); + exit(cc != sizeof(err)); } close(pipe_w);