From: Tim Beale Date: Thu, 9 Aug 2018 03:34:51 +0000 (+1200) Subject: netcmd: Fix kerberos option for domain backups X-Git-Tag: tdb-1.3.17~2176 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8fb706c34682bf6dc6033963518c7eccffc3944f;p=thirdparty%2Fsamba.git netcmd: Fix kerberos option for domain backups The previous fix still didn't work if you specified --kerberos=yes (in which case the creds still doesn't have a password). credopts.get_credentials(lp) should be enough to ensure a user/password is set (it's all that the other commands seem to do). BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566 Signed-off-by: Tim Beale Reviewed-by: Andrew Bartlett Reviewed-by: Douglas Bagnall --- diff --git a/python/samba/netcmd/domain_backup.py b/python/samba/netcmd/domain_backup.py index c251bc6c7e8..cb00e46ee3e 100644 --- a/python/samba/netcmd/domain_backup.py +++ b/python/samba/netcmd/domain_backup.py @@ -158,10 +158,6 @@ def check_targetdir(logger, targetdir): def check_online_backup_args(logger, creds, server, targetdir): # Make sure we have all the required args. - u_p = {'user': creds.get_username(), - 'pass': creds.get_password()} - if None in u_p.values(): - raise CommandError("Creds required.") if server is None: raise CommandError('Server required')