From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Thu, 3 Jul 2025 09:05:22 +0000 (+0200)
Subject: Basic code to fill ns speed table from a dump
X-Git-Tag: rec-5.4.0-alpha0~41^2~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8fbc1e233e0b669439274d061a1d22e862c6dd97;p=thirdparty%2Fpdns.git

Basic code to fill ns speed table from a dump

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
---

diff --git a/pdns/recursordist/lua-recursor4.cc b/pdns/recursordist/lua-recursor4.cc
index a1e03ffcac..a91ca83fd0 100644
--- a/pdns/recursordist/lua-recursor4.cc
+++ b/pdns/recursordist/lua-recursor4.cc
@@ -529,6 +529,10 @@ void RecursorLua4::postPrepareContext() // NOLINT(readability-function-cognitive
     return std::tuple<std::string, size_t>{ret, number};
   });
 
+  d_lw->writeFunction("putIntoNSSpeedTable", [](const string& data) {
+    return SyncRes::putIntoNSSpeedTable(data);
+  });
+
   if (!d_include_path.empty()) {
     includePath(d_include_path);
   }
diff --git a/pdns/recursordist/syncres.cc b/pdns/recursordist/syncres.cc
index 7669e75a64..9b09876602 100644
--- a/pdns/recursordist/syncres.cc
+++ b/pdns/recursordist/syncres.cc
@@ -201,6 +201,11 @@ public:
     }
   }
 
+  void insert(const ComboAddress& address, float val, int last)
+  {
+    d_collection.insert(std::make_pair(address, DecayingEwma{val, last}));
+  }
+  
   // d_collection is the modifyable part of the record, we index on DNSName and timeval, and DNSName never changes
   mutable std::map<ComboAddress, DecayingEwma> d_collection;
   DNSName d_name;
@@ -303,6 +308,120 @@ public:
     return count;
   }
 
+
+  template <typename T>
+  bool putEntry(T& message)
+  {
+    DecayingEwmaCollection entry{{}};
+    while (message.next()) {
+      switch (message.tag()) {
+      case PBNSSpeedEntry::required_bytes_name:
+        entry.d_name = DNSName(message.get_bytes());
+        break;
+      case PBNSSpeedEntry::required_int64_lastgets:
+        entry.d_lastget.tv_sec = message.get_int64();
+        break;
+      case PBNSSpeedEntry::required_int64_lastgetus:
+        entry.d_lastget.tv_usec = message.get_int64();
+        break;
+      case PBNSSpeedEntry::repeated_message_map: {
+        protozero::pbf_message<PBNSSpeedMap> map = message.get_message();
+        ComboAddress address;
+        float val{};
+        int last{};
+        while (map.next()) {
+          switch (map.tag()) {
+          case PBNSSpeedMap::required_bytes_address:
+            decodeComboAddress(map, address);
+            break;
+          case PBNSSpeedMap::required_float_val:
+            val = map.get_float();
+            break;
+          case PBNSSpeedMap::required_int32_last:
+            last = map.get_int32();
+            break;
+          }
+        }
+        entry.insert(address, val, last);
+        break;
+      }
+      }
+    }
+    return insert(std::move(entry)).second;
+  }
+
+  size_t putPB(const std::string& pbuf)
+  {
+    auto log = g_slog->withName("syncres")->withValues("size", Logging::Loggable(pbuf.size()));
+    log->info(Logr::Debug, "Processing nsspeed dump");
+
+    protozero::pbf_message<PBNSSpeedDump> full(pbuf);
+    size_t count = 0;
+    size_t inserted = 0;
+    try {
+      bool protocolVersionSeen = false;
+      bool typeSeen = false;
+      while (full.next()) {
+        switch (full.tag()) {
+        case PBNSSpeedDump::required_string_version: {
+          auto version = full.get_string();
+          log = log->withValues("version", Logging::Loggable(version));
+          break;
+        }
+        case PBNSSpeedDump::required_string_identity: {
+          auto identity = full.get_string();
+          log = log->withValues("identity", Logging::Loggable(identity));
+          break;
+        }
+        case PBNSSpeedDump::required_uint64_protocolVersion: {
+          auto protocolVersion = full.get_uint64();
+          log = log->withValues("protocolVersion", Logging::Loggable(protocolVersion));
+          if (protocolVersion != 1) {
+            throw std::runtime_error("Protocol version mismatch");
+          }
+          protocolVersionSeen = true;
+          break;
+        }
+        case PBNSSpeedDump::required_int64_time: {
+          auto time = full.get_int64();
+          log = log->withValues("time", Logging::Loggable(time));
+          break;
+        }
+        case PBNSSpeedDump::required_string_type: {
+          auto type = full.get_string();
+          if (type != "PBNSSpeedDump") {
+            throw std::runtime_error("Data type mismatch");
+          }
+          typeSeen = true;
+          break;
+        }
+        case PBNSSpeedDump::repeated_message_nsspeedEntry: {
+          if (!protocolVersionSeen || !typeSeen) {
+            throw std::runtime_error("Required field missing");
+          }
+          protozero::pbf_message<PBNSSpeedEntry> message = full.get_message();
+          if (putEntry(message)) {
+            ++inserted;
+          }
+          ++count;
+          break;
+        }
+        }
+      }
+      log->info(Logr::Info, "Processed nsspeed dump", "processed", Logging::Loggable(count), "inserted", Logging::Loggable(inserted));
+      return inserted;
+    }
+    catch (const std::runtime_error& e) {
+      log->error(Logr::Error, e.what(), "Runtime exception processing cache dump");
+    }
+    catch (const std::exception& e) {
+      log->error(Logr::Error, e.what(), "Exception processing cache dump");
+    }
+    catch (...) {
+      log->error(Logr::Error, "Other exception processing cache dump");
+    }
+    return 0;
+  }
 };
 
 static LockGuarded<nsspeeds_t> s_nsSpeeds;
@@ -313,6 +432,12 @@ size_t SyncRes::getNSSpeedTable(std::string& ret)
   return copy.getPB(ret);
 }
 
+size_t SyncRes::putIntoNSSpeedTable(const std::string& ret)
+{
+  auto lock = s_nsSpeeds.lock();
+  return lock->putPB(ret);
+}
+
 class Throttle
 {
 public:
diff --git a/pdns/recursordist/syncres.hh b/pdns/recursordist/syncres.hh
index 614741abe6..0a661a71f5 100644
--- a/pdns/recursordist/syncres.hh
+++ b/pdns/recursordist/syncres.hh
@@ -171,6 +171,7 @@ public:
   static uint64_t doDumpDoTProbeMap(int fileDesc);
 
   static size_t getNSSpeedTable(std::string& ret);
+  static size_t putIntoNSSpeedTable(const std::string& ret);
 
   static int getRootNS(struct timeval now, asyncresolve_t asyncCallback, unsigned int depth, Logr::log_t);
   static void addDontQuery(const std::string& mask)