From: Simon Marchi Date: Wed, 6 May 2026 20:27:49 +0000 (-0400) Subject: gdb/testsuite: remove unused arguments to gdb_breakpoint X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9011fd4bec5f84eb4fe59ae09985da01e2591b7e;p=thirdparty%2Fbinutils-gdb.git gdb/testsuite: remove unused arguments to gdb_breakpoint These arguments don't actually do anything, remove them. Change-Id: Ifd6a18d3effc521ba410fd40280a197d37661b12 Reviewed-By: Tankut Baris Aktemur --- diff --git a/gdb/testsuite/gdb.arch/aarch64-atomic-inst.exp b/gdb/testsuite/gdb.arch/aarch64-atomic-inst.exp index 38c83d67dc4..7ebe36b2f6e 100644 --- a/gdb/testsuite/gdb.arch/aarch64-atomic-inst.exp +++ b/gdb/testsuite/gdb.arch/aarch64-atomic-inst.exp @@ -29,9 +29,7 @@ if {![runto_main]} { return } -gdb_breakpoint "[gdb_get_line_number "ldxr"]" \ - "Breakpoint $decimal at $hex" \ - "Set the breakpoint at the start of the sequence" +gdb_breakpoint "[gdb_get_line_number "ldxr"]" gdb_test "continue" "Continuing.*Breakpoint $decimal.*" \ "Continue until breakpoint" diff --git a/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp index 56854c75394..bb4eb6374a9 100644 --- a/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp +++ b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp @@ -39,12 +39,10 @@ proc do_test { displaced } { gdb_test_no_output "set displaced-stepping $displaced" set bp1 [gdb_get_line_number "lwarx"] - gdb_breakpoint "$bp1" "Breakpoint $decimal at $hex" \ - "set the breakpoint at the start of the lwarx/stwcx sequence" + gdb_breakpoint "$bp1" set bp2 [gdb_get_line_number "ldarx"] - gdb_breakpoint "$bp2" "Breakpoint $decimal at $hex" \ - "set the breakpoint at the start of the ldarx/stdcx sequence" + gdb_breakpoint "$bp2" gdb_test continue "Continuing.*Breakpoint $decimal.*" \ "continue until lwarx/stwcx start breakpoint" diff --git a/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp b/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp index db8c7582d0c..d377e29c22e 100644 --- a/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp +++ b/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp @@ -43,8 +43,7 @@ proc do_test { displaced } { gdb_test_no_output "set displaced-stepping $displaced" - gdb_breakpoint "test_atomic_sequences" "Breakpoint $decimal at $hex" \ - "set the breakpoint at the start of the test function" + gdb_breakpoint "test_atomic_sequences" gdb_test_multiple "continue" "Continue until lbarx/stbcx start breakpoint" { -re "$inferior_exited_re with code 01.\[\r\n\]+$gdb_prompt $" { @@ -57,16 +56,13 @@ proc do_test { displaced } { } set bp1 [gdb_get_line_number "lbarx" "$srcfile2"] - gdb_breakpoint "$bp1" "Breakpoint $decimal at $hex" \ - "set the breakpoint at the start of the lbarx/stbcx sequence" + gdb_breakpoint "$bp1" set bp2 [gdb_get_line_number "lharx" "$srcfile2"] - gdb_breakpoint "$bp2" "Breakpoint $decimal at $hex" \ - "set the breakpoint at the start of the lharx/sthcx sequence" + gdb_breakpoint "$bp2" set bp3 [gdb_get_line_number "lqarx" "$srcfile2"] - gdb_breakpoint "$bp3" "Breakpoint $decimal at $hex" \ - "set the breakpoint at the start of the lqarx/stqcx sequence" + gdb_breakpoint "$bp3" gdb_test continue "Continuing.*Breakpoint $decimal.*" \ "continue until lbarx/stbcx start breakpoint" diff --git a/gdb/testsuite/gdb.base/gcore-memory-usage.exp b/gdb/testsuite/gdb.base/gcore-memory-usage.exp index e9a0f2a69e4..9bf9caa6978 100644 --- a/gdb/testsuite/gdb.base/gcore-memory-usage.exp +++ b/gdb/testsuite/gdb.base/gcore-memory-usage.exp @@ -61,7 +61,7 @@ proc run_test {megs max_mem} { gdb_test "attach $inferior_pid" "Attaching to.*" attach set line [gdb_get_line_number "TAG: BREAK HERE" $::testfile.c] - gdb_breakpoint "${::srcfile}:$line" "break at to known line" + gdb_breakpoint "${::srcfile}:$line" gdb_continue_to_breakpoint "continue to known line" # Get the important info. diff --git a/gdb/testsuite/gdb.base/valgrind-disp-step.exp b/gdb/testsuite/gdb.base/valgrind-disp-step.exp index 2b2d5b5b8e6..638774af06f 100644 --- a/gdb/testsuite/gdb.base/valgrind-disp-step.exp +++ b/gdb/testsuite/gdb.base/valgrind-disp-step.exp @@ -35,7 +35,7 @@ if { [vgdb_start] == -1 } { } gdb_test_no_output "set displaced-stepping off" -gdb_breakpoint "main" "breakpoint at main" +gdb_breakpoint "main" gdb_test "continue" " stop 0 .*" "continue to main" delete_breakpoints diff --git a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp index 9dea7d0e3d4..9f4d6068429 100644 --- a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp +++ b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp @@ -28,7 +28,7 @@ if {![runto_main]} { return } -gdb_breakpoint [gdb_get_line_number "start_again"] "Breakpoint $decimal at $hex" "start_again" +gdb_breakpoint [gdb_get_line_number "start_again"] set sizes {1 2 4 8} array set alignedend {1 1 2 2 3 4 4 4 5 8 6 8 7 8 8 8} @@ -164,8 +164,7 @@ proc size8twice { function cmd offset index } { # Set a breakpoint. set bp_src_string "${function}_return" set bp_loc [gdb_get_line_number $bp_src_string] - gdb_breakpoint $bp_loc \ - "Breakpoint $::decimal at $::hex" "$bp_src_string" + gdb_breakpoint $bp_loc # Set a hardware watchpoint. set watch_index [expr {$offset + $index}] diff --git a/gdb/testsuite/gdb.threads/fork-thread-pending.exp b/gdb/testsuite/gdb.threads/fork-thread-pending.exp index 0cf4878d13f..46c0a6f867a 100644 --- a/gdb/testsuite/gdb.threads/fork-thread-pending.exp +++ b/gdb/testsuite/gdb.threads/fork-thread-pending.exp @@ -29,7 +29,7 @@ if {![runto_main]} { gdb_test_no_output "set follow-fork-mode child" "1, set follow-fork-mode child" gdb_test "catch fork" "Catchpoint \[0-9\]* \\(fork\\)" "1, insert fork catchpoint" -gdb_breakpoint "start" "" "1, set breakpoint at start" +gdb_breakpoint "start" gdb_test "continue" "Catchpoint.*" "1, get to the fork event" diff --git a/gdb/testsuite/gdb.threads/multiple-step-overs.exp b/gdb/testsuite/gdb.threads/multiple-step-overs.exp index 2159718f2a6..de45ccefe8d 100644 --- a/gdb/testsuite/gdb.threads/multiple-step-overs.exp +++ b/gdb/testsuite/gdb.threads/multiple-step-overs.exp @@ -101,7 +101,7 @@ foreach displaced { "off" "on" } { # Switch back to thread 1, and continue. gdb_test "thread 1" "Switching.*" "switch back to thread 1" - gdb_breakpoint "sigusr1_handler" "set break at sigusr1_handler" + gdb_breakpoint "sigusr1_handler" set msg "continue to sigusr1_handler" gdb_test_multiple "continue" $msg { diff --git a/gdb/testsuite/gdb.threads/thread-bp-deleted.exp b/gdb/testsuite/gdb.threads/thread-bp-deleted.exp index 53047e3fc1d..95ce8087325 100644 --- a/gdb/testsuite/gdb.threads/thread-bp-deleted.exp +++ b/gdb/testsuite/gdb.threads/thread-bp-deleted.exp @@ -96,8 +96,7 @@ proc check_for_thread_specific_breakpoint { testname bpnum expected } { # Create a thread-specific breakpoint. This will never actually be hit; we # don't care, we just want to see GDB auto-delete this breakpoint. -gdb_breakpoint "main thread $worker_thread" \ - "create a thread-specific breakpoint" +gdb_breakpoint "main thread $worker_thread" set bpnum [get_integer_valueof "\$bpnum" "INVALID" \ "get number for thread-specific breakpoint"]