From: dastarothx Date: Sat, 23 May 2026 16:40:20 +0000 (-0400) Subject: wifi-scripts: ucode: fix null dereference for 6GHz-only radios X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=903310097b458087e7d8095aea5cbcb70159cc7b;p=thirdparty%2Fopenwrt.git wifi-scripts: ucode: fix null dereference for 6GHz-only radios he_phy_cap and he_mac_cap in phy_capabilities are only populated inside the iftype_data loop. On 6GHz-only radios (e.g. QCN9074/ath11k_pci), when capability bytes are unavailable they remain null, causing null dereferences in device_htmode_append(): Reference error: left-hand side expression is null if (!(he_phy_cap[3] & 0x80)) Initialise both to [] before the loop and guard the consumer side with ?? [] so bitwise checks conservatively disable beamformer/beamformee/twt features rather than crashing. Link: https://github.com/openwrt/openwrt/issues/23488 Signed-off-by: dastarothx Link: https://github.com/openwrt/openwrt/pull/23496 Signed-off-by: Christian Marangi --- diff --git a/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/hostapd.uc b/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/hostapd.uc index 8c96874f427..e23ea7f8098 100644 --- a/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/hostapd.uc +++ b/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/hostapd.uc @@ -470,6 +470,8 @@ function device_capabilities(config) { phy_capabilities.ht_capa = band.ht_capa ?? 0; phy_capabilities.vht_capa = band.vht_capa ?? 0; + phy_capabilities.he_mac_cap = []; + phy_capabilities.he_phy_cap = []; for (let iftype in band.iftype_data) { if (!iftype.iftypes.ap) continue;