From: Alan T. DeKok <aland@freeradius.org>
Date: Sat, 16 May 2020 21:09:10 +0000 (-0400)
Subject: shut up stupid analyzer
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=904fe85617c167bdcd2cb497ef56aa1847a6dc22;p=thirdparty%2Ffreeradius-server.git

shut up stupid analyzer

it's too stupid to know that while 'cp' isn't used inside of the
loop, it *is* used in the loop condition.
---

diff --git a/src/modules/proto_detail/proto_detail.c b/src/modules/proto_detail/proto_detail.c
index 5bf34644e6f..15989f031cc 100644
--- a/src/modules/proto_detail/proto_detail.c
+++ b/src/modules/proto_detail/proto_detail.c
@@ -512,9 +512,13 @@ static int mod_instantiate(void *instance, CONF_SECTION *conf)
 	/*
 	 *	Instantiate the process module.
 	 */
-	while ((cp = cf_pair_find_next(conf, cp, "type"))) {
+	while ((cp = cf_pair_find_next(conf, cp, "type")) != NULL) {
 		fr_app_worker_t const *app_process;
 
+#ifdef __clang_analyzer__
+		DEBUG("Instantiating %s", cf_pair_value(cp));
+#endif
+
 		app_process = (fr_app_worker_t const *)inst->type_submodule->module->common;
 		if (app_process->instantiate && (app_process->instantiate(inst->type_submodule->data,
 									  inst->type_submodule->conf) < 0)) {