From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Wed, 3 Dec 2025 08:54:23 +0000 (+0100)
Subject: 1643563 Variable copied when it could be moved
X-Git-Tag: rec-5.4.0-alpha1~28^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=905286e3796cd2c756fc103db93edd5d2ab1b60c;p=thirdparty%2Fpdns.git

1643563 Variable copied when it could be moved

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
---

diff --git a/pdns/recursordist/rec-lua-conf.cc b/pdns/recursordist/rec-lua-conf.cc
index 0baece0efb..fb49e46a6b 100644
--- a/pdns/recursordist/rec-lua-conf.cc
+++ b/pdns/recursordist/rec-lua-conf.cc
@@ -776,7 +776,7 @@ void loadRecursorLuaConfig(const std::string& fname, ProxyMapping& proxyMapping,
           smn->add(subnet.second);
         }
       }
-      proxyMapping.insert_or_assign(netmask, {address, smn});
+      proxyMapping.insert_or_assign(netmask, {std::move(address), std::move(smn)});
     }
     catch (std::exception& e) {
       lci.d_slog->error(Logr::Error, e.what(), "Exception processing addProxyMapping", "exception", Logging::Loggable("std::exception"));