From: Ondřej Kuzník <ondra@mistotebe.net>
Date: Wed, 31 Aug 2022 16:28:42 +0000 (+0100)
Subject: ITS#9908 slapd-tester: plug LDAP* leak on bind retries
X-Git-Tag: OPENLDAP_REL_ENG_2_5_14~90
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=909c1baafa5bddc2dba72015a32f60738da33689;p=thirdparty%2Fopenldap.git

ITS#9908 slapd-tester: plug LDAP* leak on bind retries
---

diff --git a/tests/progs/slapd-common.c b/tests/progs/slapd-common.c
index d9f509e6fe..d28bdb3f50 100644
--- a/tests/progs/slapd-common.c
+++ b/tests/progs/slapd-common.c
@@ -522,6 +522,8 @@ retry:;
 
 		if ( rc != LDAP_SUCCESS ) {
 			tester_ldap_error( ld, "ldap_sasl_bind_s", NULL );
+			ldap_unbind_ext( ld, NULL, NULL );
+			ld = NULL;
 			switch ( rc ) {
 				case LDAP_BUSY:
 				case LDAP_UNAVAILABLE:
@@ -533,8 +535,6 @@ retry:;
 						goto retry;
 					}
 			}
-			ldap_unbind_ext( ld, NULL, NULL );
-			ld = NULL;
 			if ( !( flags & TESTER_INIT_NOEXIT ))
 				exit( EXIT_FAILURE );
 		}