From: Tim Wiederhake <twiederh@redhat.com>
Date: Thu, 22 Apr 2021 10:32:49 +0000 (+0200)
Subject: virDomainDiskDef: Change type of error_policy to virDomainDiskErrorPolicy
X-Git-Tag: v7.3.0-rc1~53
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=90a50b98f61920eb3d2beb3be40cfcdb67c1c92d;p=thirdparty%2Flibvirt.git

virDomainDiskDef: Change type of error_policy to virDomainDiskErrorPolicy

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 33c6412642..4a0358831b 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -8976,11 +8976,15 @@ virDomainDiskDefDriverParseXML(virDomainDiskDef *def,
     }
     VIR_FREE(tmp);
 
-    if ((tmp = virXMLPropString(cur, "error_policy")) &&
-        (def->error_policy = virDomainDiskErrorPolicyTypeFromString(tmp)) <= 0) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                       _("unknown disk error policy '%s'"), tmp);
-        return -1;
+    if ((tmp = virXMLPropString(cur, "error_policy"))) {
+        int error_policy;
+
+        if ((error_policy = virDomainDiskErrorPolicyTypeFromString(tmp)) <= 0) {
+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                           _("unknown disk error policy '%s'"), tmp);
+            return -1;
+        }
+        def->error_policy = error_policy;
     }
     VIR_FREE(tmp);
 
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 3675e26eb0..cacb9d0430 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -567,7 +567,7 @@ struct _virDomainDiskDef {
     char *vendor;
     char *product;
     virDomainDiskCache cachemode;
-    int error_policy;  /* enum virDomainDiskErrorPolicy */
+    virDomainDiskErrorPolicy error_policy;
     int rerror_policy; /* enum virDomainDiskErrorPolicy */
     int iomode; /* enum virDomainDiskIo */
     virTristateSwitch ioeventfd;