From: Mark Michelson Date: Tue, 15 May 2012 23:39:06 +0000 (+0000) Subject: Correct misuse of ast_strip_quoted() when getting a Diversion header's reason parameter. X-Git-Tag: 10.6.0-rc1~39 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=90b2dabd092861c583fe7ad51fd860140f49b938;p=thirdparty%2Fasterisk.git Correct misuse of ast_strip_quoted() when getting a Diversion header's reason parameter. The use here was assuming that the pointer would be updated, but the updated string is actually returned by ast_strip_quoted() instead. ........ Merged revisions 366597 from http://svn.asterisk.org/svn/asterisk/branches/1.8 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10@366598 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- diff --git a/channels/chan_sip.c b/channels/chan_sip.c index d87a267d46..c1272dfa40 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -15662,7 +15662,7 @@ static int get_rdnis(struct sip_pvt *p, struct sip_request *oreq, char **name, c } /* Remove enclosing double-quotes */ if (*reason_param == '"') - ast_strip_quoted(reason_param, "\"", "\""); + reason_param = ast_strip_quoted(reason_param, "\"", "\""); if (!ast_strlen_zero(reason_param)) { sip_set_redirstr(p, reason_param); if (p->owner) {