From: Gary Dismukes Date: Wed, 2 Nov 2022 23:02:34 +0000 (-0400) Subject: ada: Crash on applying 'Pos to expression of a type derived from a formal type X-Git-Tag: basepoints/gcc-14~3194 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=90b9052e0b5df49d6c298c4706978135d2af2a86;p=thirdparty%2Fgcc.git ada: Crash on applying 'Pos to expression of a type derived from a formal type The compiler crashes when trying to do a static check for a range violation in a type conversion of a Pos attribute applied to a prefix of a type derived from a generic formal discrete type. This optimization was suppressed in the case of formal types, because the upper bound may not be known, but it also needs to be suppressed for types derived from formal types. gcc/ada/ * checks.adb (Apply_Type_Conversion_Checks): Apply Root_Type to the type of the prefix of a Pos attribute when checking whether the type is a formal discrete type. --- diff --git a/gcc/ada/checks.adb b/gcc/ada/checks.adb index 968766728715..2a45f4d49b02 100644 --- a/gcc/ada/checks.adb +++ b/gcc/ada/checks.adb @@ -3789,13 +3789,14 @@ package body Checks is -- Universal_Integer. So in numeric conversions it is usually -- within range of the target integer type. Use the static -- bounds of the base types to check. Disable this optimization - -- in case of a generic formal discrete type, because we don't - -- necessarily know the upper bound yet. + -- in case of a descendant of a generic formal discrete type, + -- because we don't necessarily know the upper bound yet. if Nkind (Expr) = N_Attribute_Reference and then Attribute_Name (Expr) = Name_Pos and then Is_Enumeration_Type (Etype (Prefix (Expr))) - and then not Is_Generic_Type (Etype (Prefix (Expr))) + and then + not Is_Generic_Type (Root_Type (Etype (Prefix (Expr)))) and then Is_Integer_Type (Target_Type) then declare