From: Josh Law <objecting@objecting.org>
Date: Sun, 1 Mar 2026 20:38:45 +0000 (+0000)
Subject: lib/glob: clean up "bool abuse" in pointer arithmetic
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=90c73d0bfa36ea80f3a55f5426daa46fa2795957;p=thirdparty%2Fkernel%2Fstable.git

lib/glob: clean up "bool abuse" in pointer arithmetic

Replace the implicit 'bool' to 'int' conversion with an explicit ternary
operator.  This makes the pointer arithmetic clearer and avoids relying on
boolean memory representation for logic flow.

Link: https://lkml.kernel.org/r/20260301203845.2617217-1-objecting@objecting.org
Signed-off-by: Josh Law <objecting@objecting.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

diff --git a/lib/glob.c b/lib/glob.c
index 877bdd0884a6..69311568ad3d 100644
--- a/lib/glob.c
+++ b/lib/glob.c
@@ -73,7 +73,7 @@ bool __pure glob_match(char const *pat, char const *str)
 			if (c == '\0')	/* No possible match */
 				return false;
 			bool match = false, inverted = (*pat == '!');
-			char const *class = pat + inverted;
+			char const *class = inverted ? pat + 1 : pat;
 			unsigned char a = *class++;
 
 			/*