From: Gary Lockyer <gary@catalyst.net.nz>
Date: Thu, 15 Jan 2026 03:10:04 +0000 (+1300)
Subject: s3:utils:status_json fix Non-boolean returned
X-Git-Tag: tdb-1.4.15~60
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=90c806d3083d4e88d8c6626becd50b322117f213;p=thirdparty%2Fsamba.git

s3:utils:status_json fix Non-boolean returned

Fix cppcheck

source3/utils/status_json.c:1385:3: style: Non-boolean value returned
    from function returning bool [returnNonBoolInBooleanFunction]

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15924

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Anoop C S <anoopcs@samba.org>

Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Thu Jan 15 09:18:21 UTC 2026 on atb-devel-224
---

diff --git a/source3/utils/status_json.c b/source3/utils/status_json.c
index fba0f40508f..169cea69960 100644
--- a/source3/utils/status_json.c
+++ b/source3/utils/status_json.c
@@ -1383,7 +1383,7 @@ bool print_notify_rec_json(struct traverse_state *state,
 
 	TALLOC_CTX *tmp_ctx = talloc_stackframe();
 	if (tmp_ctx == NULL) {
-		return -1;
+		return false;
 	}
 
 	sub_json = json_new_object();