From: Paul Eggert Date: Wed, 3 Nov 2004 23:12:55 +0000 (+0000) Subject: (check-AUTHORS): Don't assume \? works in a sed X-Git-Tag: v5.3.0~469 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=90d6db1fbb0c6f091b0840f251974536da698640;p=thirdparty%2Fcoreutils.git (check-AUTHORS): Don't assume \? works in a sed expression; it's not portable. Problem reported by Albert Chin. Don't invoke a program more than once. --- diff --git a/src/Makefile.am b/src/Makefile.am index 3295697998..d1c039f0c1 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -248,7 +248,7 @@ au_actual = authors-actual .PHONY: check-AUTHORS check-AUTHORS: $(all_programs) rm -f $(au_actual) $(au_dotdot) - for i in $(all_programs); do \ + for i in `ls $(all_programs) | $(ASSORT) -u`; do \ test "$$i" = '[' && continue; \ exe=$$i; \ if test "$$i" = install; then \ @@ -256,11 +256,9 @@ check-AUTHORS: $(all_programs) elif test "$$i" = test; then \ exe='['; \ fi; \ - ./printf "$$i: "; \ ./$$exe --version \ - |sed -n '/Written by /s///p' \ - |sed 's/,\? and /, /;s/\.$$//'; \ - done | $(ASSORT) > $(au_actual) + |sed -n '/Written by /{ s//'"$$i"': /; s/,* and /, /; s/\.$$//; p; }'; \ + done > $(au_actual) sed -n '/:/p' $(top_srcdir)/AUTHORS > $(au_dotdot) diff $(au_actual) $(au_dotdot) && rm -f $(au_actual) $(au_dotdot)