From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Thu, 24 Jul 2025 12:31:46 +0000 (+0200)
Subject: getty-generator: improve debugging messages
X-Git-Tag: v258-rc2~64^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9154cc7e80787e0c42b547c4305941b316d772d4;p=thirdparty%2Fsystemd.git

getty-generator: improve debugging messages

We generally log what happens, but we didn't log anything about checking credentials,
so add that.

The error message when we cannot acces /proc/1/environ was confusing.
---

diff --git a/src/getty-generator/getty-generator.c b/src/getty-generator/getty-generator.c
index cd9aae51e34..bedfda81bd3 100644
--- a/src/getty-generator/getty-generator.c
+++ b/src/getty-generator/getty-generator.c
@@ -137,6 +137,8 @@ static int add_credential_gettys(void) {
         };
         int r;
 
+        log_debug("Checking credentials for configuration...");
+
         FOREACH_ELEMENT(t, table) {
                 _cleanup_free_ char *b = NULL;
                 size_t sz = 0;
@@ -247,11 +249,12 @@ static void parse_env(void) {
 
         r = getenv_for_pid(1, "SYSTEMD_GETTY_AUTO", &value);
         if (r < 0)
-                log_warning_errno(r, "Failed to parse $SYSTEMD_GETTY_AUTO environment variable, ignoring: %m");
+                log_warning_errno(r, "Failed to read $SYSTEMD_GETTY_AUTO in PID 1's environment, ignoring: %m");
         else if (r > 0) {
                 r = parse_getty_sources(value, &arg_getty_sources);
                 if (r < 0)
-                        log_warning_errno(r, "Failed to parse $SYSTEMD_GETTY_AUTO environment variable, ignoring: %s", value);
+                        log_warning_errno(r, "Failed to parse $SYSTEMD_GETTY_AUTO from PID 1's environment, ignoring: %s",
+                                          value);
         }
 }
 
@@ -314,8 +317,8 @@ static int run(const char *dest, const char *dest_early, const char *dest_late)
                         log_warning_errno(r, "Failed to get active kernel consoles, ignoring: %m");
                 else if (r > 0)
                         STRV_FOREACH(i, consoles) {
-                                /* We assume that gettys on virtual terminals are started via manual configuration
-                                 * and do this magic only for non-VC terminals. */
+                                /* We assume that gettys on virtual terminals are started via manual
+                                 * configuration and do this magic only for non-VC terminals. */
                                 if (tty_is_vc(*i))
                                         continue;