From: Rafael J. Wysocki Date: Mon, 15 Dec 2025 14:00:57 +0000 (+0100) Subject: ACPI: scan: Do not mark button ACPI devices as wakeup-capable X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=91ba8de81bcb8cea922ee9427e54798a16dfd724;p=thirdparty%2Fkernel%2Flinux.git ACPI: scan: Do not mark button ACPI devices as wakeup-capable It is generally questionable to mark struct acpi_device "devices" as wakeup-capable because they represent firmware entities that by themselves have no wakeup capabilities. It was done for struct acpi_device "devices" corresponding to buttons because the ACPI button driver was binding to them directly, but now that corresponding platform devices are created for the buttons and they are marked as wakeup-capable by the ACPI button driver, there is no reason to continue doing it. Update acpi_wakeup_gpe_init() accordingly. Signed-off-by: Rafael J. Wysocki Link: https://patch.msgid.link/2891119.BEx9A2HvPv@rafael.j.wysocki --- diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index 1bc470019298f..37f06d7e97c56 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -1023,7 +1023,6 @@ static bool acpi_wakeup_gpe_init(struct acpi_device *device) wakeup->sleep_state == ACPI_STATE_S5) wakeup->sleep_state = ACPI_STATE_S4; acpi_mark_gpe_for_wake(wakeup->gpe_device, wakeup->gpe_number); - device_set_wakeup_capable(&device->dev, true); return true; }