From: Tom Hromatka <tom.hromatka@oracle.com>
Date: Tue, 7 Jan 2020 18:47:22 +0000 (-0700)
Subject: api.c: Fix double free in cgroup_create_template_group()
X-Git-Tag: v0.42~3^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=91cccef4b472da3ef90ed4a31bc68717a491139a;p=thirdparty%2Flibcgroup.git

api.c: Fix double free in cgroup_create_template_group()

Coverity identified a double free situation:

CID 1412117 (#1 of 1): Double free (USE_AFTER_FREE)7. double_free:
Calling free frees pointer template_name which has already been freed.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
---

diff --git a/src/api.c b/src/api.c
index 30962fcc..c37855f3 100644
--- a/src/api.c
+++ b/src/api.c
@@ -3227,6 +3227,7 @@ static int cgroup_create_template_group(char *orig_group_name,
 		ret = ECGOTHER;
 		last_errno = errno;
 		free(template_name);
+		template_name = NULL;
 		goto end;
 	}