From: Uwe Kleine-König Date: Wed, 30 Apr 2025 09:57:48 +0000 (+0200) Subject: clk: pwm: Don't reconfigure running PWM at probe time X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=91d10161226c1edfb1354441ad78b9ae679a6108;p=thirdparty%2Flinux.git clk: pwm: Don't reconfigure running PWM at probe time If the PWM is enabled already when .probe() is entered, period and duty_cycle are updated which essentially corresponds to a clock frequency change. This is unusual and surprising. So update the settings only when the clock gets prepared. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/a974f1147e1a080bf5ad7f1752c92b24516df284.1746006578.git.ukleinek@baylibre.com Signed-off-by: Stephen Boyd --- diff --git a/drivers/clk/clk-pwm.c b/drivers/clk/clk-pwm.c index f5e6fef3f4d5d..856828d5f58c4 100644 --- a/drivers/clk/clk-pwm.c +++ b/drivers/clk/clk-pwm.c @@ -109,12 +109,6 @@ static int clk_pwm_probe(struct platform_device *pdev) pwm_init_state(pwm, &clk_pwm->state); pwm_set_relative_duty_cycle(&clk_pwm->state, 1, 2); - - ret = pwm_apply_might_sleep(pwm, &clk_pwm->state); - if (ret < 0) - return ret; - - /* set enabled only now to not enable output above */ clk_pwm->state.enabled = true; clk_name = node->name;