From: Simon Marchi Date: Wed, 29 Apr 2020 09:24:41 +0000 (+0200) Subject: Makeconfig: Use $(error ...) to output error message X-Git-Tag: glibc-2.32~390 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9207e30d3f070712df6c4175547094be112454d2;p=thirdparty%2Fglibc.git Makeconfig: Use $(error ...) to output error message Being not familiar with the glibc repository, I typed "make" inside some subdirectory that has a Makefile, and was met with: $ make ../Makeconfig:42: *** missing separator. Stop. At Makeconfig:42, we have: objdir must be defined by the build-directory Makefile. Change that to use $(error ...), which I guess was the original intention. The result is: $ make ../Makeconfig:42: *** objdir must be defined by the build-directory Makefile. Stop. --- diff --git a/Makeconfig b/Makeconfig index ac567caddc1..dfda418aacc 100644 --- a/Makeconfig +++ b/Makeconfig @@ -39,7 +39,7 @@ objpfx := $(patsubst %//,%/,$(objdir)/$(subdir)/) common-objpfx = $(objdir)/ common-objdir = $(objdir) else -objdir must be defined by the build-directory Makefile. +$(error objdir must be defined by the build-directory Makefile) endif # Root of the sysdeps tree.