From: Paolo Bonzini <pbonzini@redhat.com>
Date: Mon, 14 Dec 2009 13:09:10 +0000 (+0100)
Subject: Fix possible NULL pointer dereference
X-Git-Tag: v0.7.5~92
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=921d2225ba3cb63f1f719124f58c56629ac2a7fb;p=thirdparty%2Flibvirt.git

Fix possible NULL pointer dereference

If there are no references remaining to the object, vm is set to NULL
and vm->persistent cannot be accessed.  Fixed by this trivial patch.

* src/qemu/qemu_driver.c (qemudDomainCoreDump): Avoid possible
  NULL pointer dereference on --crash dump.
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 3946c27665..faeb8385cd 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -3914,7 +3914,7 @@ endjob:
 
     if (qemuDomainObjEndJob(vm) == 0)
         vm = NULL;
-    if ((ret == 0) && (flags & VIR_DUMP_CRASH) && !vm->persistent) {
+    else if ((ret == 0) && (flags & VIR_DUMP_CRASH) && !vm->persistent) {
         virDomainRemoveInactive(&driver->domains,
                                 vm);
         vm = NULL;