From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Tue, 16 Jul 2019 10:15:41 +0000 (+0200)
Subject: Merge branch 'master' into dev-metrics
X-Git-Tag: dnsdist-1.4.0-rc3~31^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=921f627469a00fc03a7246089e6aae0ff41cfc27;p=thirdparty%2Fpdns.git

Merge branch 'master' into dev-metrics
---

921f627469a00fc03a7246089e6aae0ff41cfc27
diff --cc regression-tests.api/test_Servers.py
index ba64df3a48,6b30359e38..66a183058f
--- a/regression-tests.api/test_Servers.py
+++ b/regression-tests.api/test_Servers.py
@@@ -69,16 -71,8 +71,21 @@@ class Servers(ApiTestCase)
          self.assertEquals(r.status_code, 422)
          self.assertIn("Unknown statistic name", r.json()['error'])
  
- 
 +    def test_read_metrics(self):
 +        if is_recursor():
 +            res = self.session.get(self.url("/metrics"), auth=('whatever', self.webServerBasicAuthPassword), timeout=2.0)
 +            self.assertEqual(res.status_code, 200)
 +            # print(res.text)
 +            found = False
 +            for line in res.text.splitlines():
 +                if line[0] == "#":
 +                    continue
 +                if line.split(" ")[0] == "pdnsrecursor_uptime":
 +                    found = True
 +            self.assertTrue(found,"pdnsrecursor_uptime is missing")
++            
+     @unittest.skipIf(is_auth(), "Not applicable")
+     def test_read_statistics_using_password(self):
+         r = requests.get(self.url("/api/v1/servers/localhost/statistics"), auth=('admin', self.server_web_password))
+         self.assertEquals(r.status_code, requests.codes.ok)
+         self.assert_success_json(r)
diff --cc regression-tests.api/test_helper.py
index 5df46745ef,9a6ee02820..c5dbcee20d
--- a/regression-tests.api/test_helper.py
+++ b/regression-tests.api/test_helper.py
@@@ -23,9 -23,9 +23,10 @@@ class ApiTestCase(unittest.TestCase)
      def setUp(self):
          # TODO: config
          self.server_address = '127.0.0.1'
 +        self.webServerBasicAuthPassword = 'something'
          self.server_port = int(os.environ.get('WEBPORT', '5580'))
          self.server_url = 'http://%s:%s/' % (self.server_address, self.server_port)
+         self.server_web_password = os.environ.get('WEBPASSWORD', 'MISSING')
          self.session = requests.Session()
          self.session.headers = {'X-API-Key': os.environ.get('APIKEY', 'changeme-key'), 'Origin': 'http://%s:%s' % (self.server_address, self.server_port)}