From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 17 Feb 2025 10:19:11 +0000 (+0100)
Subject: qemuDomainGetStatsBlockExportBackendStorage: Remove return value
X-Git-Tag: v11.1.0-rc1~46
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=924805d29cc1ddffac1e1b0c403f4c17e31068dc;p=thirdparty%2Flibvirt.git

qemuDomainGetStatsBlockExportBackendStorage: Remove return value

The function always returns 0. Remove return value and fix callers.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 3dee0a4a91..327edfe506 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17314,7 +17314,7 @@ qemuDomainGetStatsOneBlock(virQEMUDriverConfig *cfg,
 }
 
 
-static int
+static void
 qemuDomainGetStatsBlockExportBackendStorage(const char *entryname,
                                             GHashTable *stats,
                                             size_t recordnr,
@@ -17323,12 +17323,10 @@ qemuDomainGetStatsBlockExportBackendStorage(const char *entryname,
     qemuBlockStats *entry;
 
     if (!stats || !entryname || !(entry = virHashLookup(stats, entryname)))
-        return 0;
+        return;
 
     if (entry->write_threshold)
         virTypedParamListAddULLong(params, entry->write_threshold, "block.%zu.threshold", recordnr);
-
-    return 0;
 }
 
 
@@ -17448,10 +17446,8 @@ qemuDomainGetStatsBlockExportDisk(virDomainDiskDef *disk,
                                        stats) < 0)
             return -1;
 
-        if (qemuDomainGetStatsBlockExportBackendStorage(backendstoragealias,
-                                                        stats, *recordnr,
-                                                        params) < 0)
-            return -1;
+        qemuDomainGetStatsBlockExportBackendStorage(backendstoragealias,
+                                                    stats, *recordnr, params);
 
         (*recordnr)++;
 
@@ -17476,10 +17472,8 @@ qemuDomainGetStatsBlockExportDisk(virDomainDiskDef *disk,
                                            stats) < 0)
                 return -1;
 
-            if (qemuDomainGetStatsBlockExportBackendStorage(qemuBlockStorageSourceGetStorageNodename(disk->mirror),
-                                                            stats, *recordnr,
-                                                            params) < 0)
-                return -1;
+            qemuDomainGetStatsBlockExportBackendStorage(qemuBlockStorageSourceGetStorageNodename(disk->mirror),
+                                                        stats, *recordnr, params);
 
             (*recordnr)++;
         }
@@ -17504,10 +17498,9 @@ qemuDomainGetStatsBlockExportDisk(virDomainDiskDef *disk,
                                                    stats) < 0)
                         return -1;
 
-                    if (qemuDomainGetStatsBlockExportBackendStorage(qemuBlockStorageSourceGetStorageNodename(backupdisk->store),
-                                                                    stats, *recordnr,
-                                                                    params) < 0)
-                        return -1;
+                    qemuDomainGetStatsBlockExportBackendStorage(qemuBlockStorageSourceGetStorageNodename(backupdisk->store),
+                                                                stats, *recordnr,
+                                                                params);
 
                     (*recordnr)++;
                 }