From: Chien Wong <m@xv97.com>
Date: Sat, 27 Apr 2024 08:19:44 +0000 (+0800)
Subject: NAN: Reject undefined publish type
X-Git-Tag: hostap_2_11~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=92829d8bee63c0efc9849bdaa3e71a5201a2eb89;p=thirdparty%2Fhostap.git

NAN: Reject undefined publish type

The Wi-Fi Aware Specification v4.0 only defines unsolicited
transmissions only, solicited transmissions only and both unsolicited
and solicited transmissions publish. The other possibility is undefined
so we should reject it.

Signed-off-by: Chien Wong <m@xv97.com>
---

diff --git a/src/common/nan_de.c b/src/common/nan_de.c
index e1999a06b..12fad3112 100644
--- a/src/common/nan_de.c
+++ b/src/common/nan_de.c
@@ -1209,6 +1209,12 @@ int nan_de_publish(struct nan_de *de, const char *service_name,
 		return -1;
 	}
 
+	if (!params->unsolicited && !params->solicited) {
+		wpa_printf(MSG_INFO,
+			   "NAN: Publish() - both unsolicited and solicited disabled is invalid");
+		return -1;
+	}
+
 	publish_id = nan_de_get_handle(de);
 	if (publish_id < 1)
 		return -1;