From: Petr Vorel Date: Tue, 25 Sep 2018 12:49:56 +0000 (+0200) Subject: testsuite: Fix make check when need build generate_nlmsg X-Git-Tag: v4.19.0~9 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=92885e1973a5493980dc1341cb469504e7203cdc;p=thirdparty%2Fiproute2.git testsuite: Fix make check when need build generate_nlmsg make check from top level Makefile defines several flags which break building generate_nlmsg: $ make check make -C tools gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wformat=2 -O2 -I../include -I../include/uapi -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -DNETNS_RUN_DIR=\"/var/run/netns\" -DNETNS_ETC_DIR=\"/etc/netns\" -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DHAVE_SETNS -DHAVE_SELINUX -DHAVE_ELF -DHAVE_LIBMNL -I/usr/include/libmnl -DNEED_STRLCPY -DHAVE_LIBCAP ../lib/libutil.a ../lib/libnetlink.a -lselinux -lelf -lmnl -lcap -I../../include -include../../include/uapi/linux/netlink.h -o generate_nlmsg generate_nlmsg.c ../../lib/libnetlink.c -lmnl gcc: error: ../lib/libutil.a: No such file or directory gcc: error: ../lib/libnetlink.a: No such file or directory make[2]: *** [Makefile:5: generate_nlmsg] Error 1 make[1]: *** [Makefile:40: generate_nlmsg] Error 2 To fix it reset CFLAGS in sub Makefile and remove LDLIBS entirely (as required -lmnl flag was specified in 5dc2204c ("testsuite: add libmnl"). Fixes: 8804a8c0 ("Makefile: Add check target") Signed-off-by: Petr Vorel Signed-off-by: Stephen Hemminger --- diff --git a/testsuite/tools/Makefile b/testsuite/tools/Makefile index 7d53d2266..e1d9bfef4 100644 --- a/testsuite/tools/Makefile +++ b/testsuite/tools/Makefile @@ -1,8 +1,9 @@ # SPDX-License-Identifier: GPL-2.0 +CFLAGS= include ../../config.mk generate_nlmsg: generate_nlmsg.c ../../lib/libnetlink.c - $(CC) $(CPPFLAGS) $(CFLAGS) $(LDLIBS) $(EXTRA_CFLAGS) -I../../include -include../../include/uapi/linux/netlink.h -o $@ $^ -lmnl + $(CC) $(CPPFLAGS) $(CFLAGS) $(EXTRA_CFLAGS) -I../../include -include../../include/uapi/linux/netlink.h -o $@ $^ -lmnl clean: rm -f generate_nlmsg