From: Jan Hak <jan.hak@nic.cz>
Date: Thu, 30 Jan 2020 10:03:17 +0000 (+0100)
Subject: kdig: return error when queried domain name is ilegal
X-Git-Tag: embedded_lmdb~81
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=928c598113cbae8bb43ae99bbe621afecd059eee;p=thirdparty%2Fknot-dns.git

kdig: return error when queried domain name is ilegal
---

diff --git a/src/utils/kdig/kdig_exec.c b/src/utils/kdig/kdig_exec.c
index 6a1fb63f8b..434ced10ff 100644
--- a/src/utils/kdig/kdig_exec.c
+++ b/src/utils/kdig/kdig_exec.c
@@ -1,4 +1,4 @@
-/*  Copyright (C) 2019 CZ.NIC, z.s.p.o. <knot-dns@labs.nic.cz>
+/*  Copyright (C) 2020 CZ.NIC, z.s.p.o. <knot-dns@labs.nic.cz>
 
     This program is free software: you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -412,8 +412,15 @@ static knot_pkt_t *create_query_packet(const query_t *query)
 	}
 
 	// Set packet question if available.
-	knot_dname_t *qname = knot_dname_from_str_alloc(query->owner);
-	if (qname != NULL) {
+	knot_dname_t *qname = NULL;
+	if (query->owner != NULL) {
+		qname = knot_dname_from_str_alloc(query->owner);
+		if (qname == NULL) {
+			ERR("'%s' is not a valid domain name\n", query->owner);
+			knot_pkt_free(packet);
+			return NULL;
+		}
+
 		int ret = knot_pkt_put_question(packet, qname, query->class_num,
 		                                query->type_num);
 		if (ret != KNOT_EOK) {