From: Antonio Alvarez Feijoo <antonio.feijoo@suse.com>
Date: Mon, 8 Apr 2024 15:08:52 +0000 (+0200)
Subject: vmspawn: fix `sd_bus_message_append()` arguments and add missing error check
X-Git-Tag: v256-rc1~262
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=92966b3ac0391316035883fb8b9cd941f3080954;p=thirdparty%2Fsystemd.git

vmspawn: fix `sd_bus_message_append()` arguments and add missing error check
---

diff --git a/src/vmspawn/vmspawn-scope.c b/src/vmspawn/vmspawn-scope.c
index a8d27afa113..58f6781b77a 100644
--- a/src/vmspawn/vmspawn-scope.c
+++ b/src/vmspawn/vmspawn-scope.c
@@ -56,10 +56,12 @@ int start_transient_scope(sd_bus *bus, const char *machine_name, bool allow_pidf
         if (r < 0)
                 return bus_log_create_error(r);
 
-        r = sd_bus_message_append(m, "(sa)(sa)(sa)",
+        r = sd_bus_message_append(m, "(sv)(sv)(sv)",
                                   "Description", "s",  description,
                                   "AddRef",      "b",  1,
                                   "CollectMode", "s",  "inactive-or-failed");
+        if (r < 0)
+                return bus_log_create_error(r);
 
         _cleanup_(pidref_done) PidRef pidref = PIDREF_NULL;
         r = pidref_set_self(&pidref);