From: Andrea Claudi <aclaudi@redhat.com>
Date: Mon, 19 Apr 2021 13:49:56 +0000 (+0200)
Subject: lib: bpf_legacy: treat 0 as a valid file descriptor
X-Git-Tag: v5.12.0~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=92af24c9078e0c3f3d3c191d78db91fe10df6bc1;p=thirdparty%2Fiproute2.git

lib: bpf_legacy: treat 0 as a valid file descriptor

As stated in the man page(), open returns a non-negative integer as a
file descriptor. Hence, when checking for its return value to be ok, we
should include 0 as a valid value.

This fixes a covscan warning about a missing close() in this function.

Fixes: ecb05c0f997d ("bpf: improve error reporting around tail calls")
Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---

diff --git a/lib/bpf_legacy.c b/lib/bpf_legacy.c
index 8a03b9c2a..7ff10e4f2 100644
--- a/lib/bpf_legacy.c
+++ b/lib/bpf_legacy.c
@@ -2832,7 +2832,7 @@ static void bpf_get_cfg(struct bpf_elf_ctx *ctx)
 	int fd;
 
 	fd = open(path_jit, O_RDONLY);
-	if (fd > 0) {
+	if (fd >= 0) {
 		char tmp[16] = {};
 
 		if (read(fd, tmp, sizeof(tmp)) > 0)