From: Michael Tremer <michael.tremer@ipfire.org>
Date: Fri, 12 May 2023 16:49:47 +0000 (+0000)
Subject: builds: Perform special sorting in build groups
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=92d613a2bb0d0edd86208809f733cc7ced4b9993;p=pbs.git

builds: Perform special sorting in build groups

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/buildservice/builds.py b/src/buildservice/builds.py
index 3b221492..cb5c5089 100644
--- a/src/buildservice/builds.py
+++ b/src/buildservice/builds.py
@@ -1097,7 +1097,21 @@ class Group(base.DataObject):
 			""", self.id,
 		)
 
-		return list(builds)
+		return sorted(builds, key=self._sort_builds)
+
+	@staticmethod
+	def _sort_builds(build):
+		# Move failed builds to the top
+		if build.has_failed():
+			return (1, build)
+
+		# After that put successfully finished builds
+		elif build.is_successful():
+			return (2, build)
+
+		# After that put anything else
+		else:
+			return (3, build)
 
 	@property
 	def successful_builds(self):