From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Wed, 18 Jun 2025 07:29:55 +0000 (+0300)
Subject: lib-dict-extra: dict-client - Fix crash if server sends invalid iteration reply
X-Git-Tag: 2.4.2~659
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=92dd82ec98715ce7d77cd5fa249c63129a50fc42;p=thirdparty%2Fdovecot%2Fcore.git

lib-dict-extra: dict-client - Fix crash if server sends invalid iteration reply
---

diff --git a/src/lib-dict-extra/dict-client.c b/src/lib-dict-extra/dict-client.c
index 67c96f39b1..f2a240f022 100644
--- a/src/lib-dict-extra/dict-client.c
+++ b/src/lib-dict-extra/dict-client.c
@@ -1089,7 +1089,9 @@ client_dict_iter_async_callback(struct client_dict_cmd *cmd,
 		/* broken protocol */
 		error = t_strdup_printf("dict client (%s) sent broken iterate reply: %c%s",
 			dict->conn.conn.name, reply, value);
+		/* disconnection finishes the command */
 		client_dict_disconnect(dict, error);
+		return;
 	}
 
 	if (error != NULL) {