From: Philippe Antoine <pantoine@oisf.net>
Date: Tue, 27 Sep 2022 13:47:06 +0000 (+0200)
Subject: ssl: fix compiler warning
X-Git-Tag: suricata-6.0.10~33
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=93055383098b55a097cceb9d088b1e77d57b9439;p=thirdparty%2Fsuricata.git

ssl: fix compiler warning

implicit conversion loses integer precision: 'int' to 'uint16_t'
because C shifts << translates automatically to signed integers

(cherry picked from commit ae6abd8ca3eb0e3157eb8709d97c9432beb9e373)
---

diff --git a/src/app-layer-ssl.c b/src/app-layer-ssl.c
index 435411e4a3..c1b3779ebc 100644
--- a/src/app-layer-ssl.c
+++ b/src/app-layer-ssl.c
@@ -2080,7 +2080,7 @@ static struct SSLDecoderResult SSLv2Decode(uint8_t direction, SSLState *ssl_stat
             ssl_state->current_flags = SSL_AL_FLAG_STATE_CLIENT_HELLO;
             ssl_state->current_flags |= SSL_AL_FLAG_SSL_CLIENT_HS;
 
-            const uint16_t version = input[0] << 8 | input[1];
+            const uint16_t version = (uint16_t)(input[0] << 8) | input[1];
             SCLogDebug("SSLv2: version %04x", version);
             ssl_state->curr_connp->version = version;
             uint16_t session_id_length = (input[5]) | (uint16_t)(input[4] << 8);