From: Jim Jagielski <jim@apache.org>
Date: Thu, 9 Feb 2006 16:51:22 +0000 (+0000)
Subject: Document that we are being chunking in our
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9314f6944b59451d7a456f11fcfbbde788b56594;p=thirdparty%2Fapache%2Fhttpd.git

Document that we are being chunking in our
content passing, as compared to simply spooling
all the content in until clen == 0. Also, we
need to cleanup the brigade after each pass.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/fcgi-proxy-dev@376346 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/proxy/mod_proxy_fcgi.c b/modules/proxy/mod_proxy_fcgi.c
index fb23d74ff52..990390a5434 100644
--- a/modules/proxy/mod_proxy_fcgi.c
+++ b/modules/proxy/mod_proxy_fcgi.c
@@ -683,10 +683,21 @@ recv_again:
                             apr_bucket_setaside(b, setaside_pool);
                         }
                     } else {
+                            /* we've already passed along the headers,
+                             * so now pass through the content.
+                             * we could simply continue to setaside
+                             * the content and not pass until we
+                             * see the 0 content-length (below, where
+                             * we append the EOS), but that
+                             * could be a huge amount of data;
+                             * so we pass along smaller chunks
+                             */
                             rv = ap_pass_brigade(r->output_filters, ob);
                             if (rv != APR_SUCCESS) {
                                 break;
                             }
+                            apr_brigade_cleanup(ob);
+
                     }
 
                     /* If we didn't read all the data go back and get the