From: Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
Date: Fri, 29 Oct 2021 18:57:18 +0000 (+0300)
Subject: PCI VPD: Fix a wrong return code in a test case
X-Git-Tag: v7.10.0-rc1~236
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=935fbcf9da8d86ad2aa07e2d84e9615b5a011136;p=thirdparty%2Flibvirt.git

PCI VPD: Fix a wrong return code in a test case

The test case should return -1, not 0 in case a valid resource could
not be parsed successfully but the ret value is initialized to 0.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
---

diff --git a/tests/virpcivpdtest.c b/tests/virpcivpdtest.c
index b7bc86d922..a9405f9427 100644
--- a/tests/virpcivpdtest.c
+++ b/tests/virpcivpdtest.c
@@ -537,7 +537,6 @@ testVirPCIVPDParseFullVPD(const void *opaque G_GNUC_UNUSED)
 {
     int fd = -1;
     size_t dataLen = 0;
-    int ret = 0;
 
     g_autoptr(virPCIVPDResource) res = NULL;
     /* Note: Custom fields are supposed to be freed by the resource cleanup code. */
@@ -558,7 +557,7 @@ testVirPCIVPDParseFullVPD(const void *opaque G_GNUC_UNUSED)
     if (!res) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                        "The resource pointer is NULL after parsing which is unexpected");
-        return ret;
+        return -1;
     }
 
     if (!res->ro) {
@@ -596,7 +595,7 @@ testVirPCIVPDParseFullVPD(const void *opaque G_GNUC_UNUSED)
         return -1;
 
     custom = NULL;
-    return ret;
+    return 0;
 }
 
 static int