From: James Jones <jejones3141@gmail.com>
Date: Fri, 18 Aug 2023 13:54:39 +0000 (-0500)
Subject: Get rid of remaining unchecked return value (CID #1533664, #1524617)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=93628d338e6e7e6aae409c19ec337dcd6265b309;p=thirdparty%2Ffreeradius-server.git

Get rid of remaining unchecked return value (CID #1533664, #1524617)
---

diff --git a/src/bin/unit_test_module.c b/src/bin/unit_test_module.c
index 5122718ecf1..d28ba5d415c 100644
--- a/src/bin/unit_test_module.c
+++ b/src/bin/unit_test_module.c
@@ -481,7 +481,7 @@ static bool do_xlats(fr_event_list_t *el, char const *filename, FILE *fp)
 			if (len < 0) {
 				char const *err = fr_strerror();
 				talloc_free(xlat_ctx);
-				fr_sbuff_in_sprintf(&out, "ERROR expanding xlat: %s", *err ? err : "no error provided");
+				FR_SBUFF_IN_SPRINTF_RETURN(&out, "ERROR expanding xlat: %s", *err ? err : "no error provided");
 				continue;
 			}
 
diff --git a/src/protocols/vmps/vmps.c b/src/protocols/vmps/vmps.c
index d1ad45b2e4c..98d4d3fccd4 100644
--- a/src/protocols/vmps/vmps.c
+++ b/src/protocols/vmps/vmps.c
@@ -293,14 +293,14 @@ ssize_t fr_vmps_encode(fr_dbuff_t *dbuff, uint8_t const *original,
 
 		if (vp->da == attr_packet_type) {
 			fr_dbuff_set(&m, fr_dbuff_current(&hdr) + 1);
-			fr_dbuff_in(&m, (uint8_t)vp->vp_uint32);
+			FR_DBUFF_IN_RETURN(&m, (uint8_t)vp->vp_uint32);
 			fr_dcursor_next(cursor);
 			continue;
 		}
 
 		if (vp->da == attr_error_code) {
 			fr_dbuff_set(&m, fr_dbuff_current(&hdr) + 2);
-			fr_dbuff_in(&m, vp->vp_uint8);
+			FR_DBUFF_IN_RETURN(&m, vp->vp_uint8);
 			fr_dcursor_next(cursor);
 			continue;
 		}